Fix IPv6 address case in server_list function #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When specifying an IPv6 address in faust.App as broker, faust passes to aiokafka an incorrectly-transformed value.
e.g:
When I write this:
yarl.URL constructor receives the strings as is, but the returned object
.host
attribute is1234:5678::9abc
. So, theserver_list function
in transport/drivers/aiokafka.py creates1234:5678::9abc:9092
, which, while not syntactically incorrect, is a different IPv6 address. Also, the port information is lost in the process.I've checked the yarl module and there does not seem to be any attribute/method to retrieve the enclosed IPv6 address. This small change intend to fix this behavior, on faust side.
L156 is assumed as a "is it an IPv6 address" check. While it could be better, I found it's good enough for me. :)